search

go-vikunja / vikunja

Mirror of vikunja from https://code.vikunja.io/api
GNU Affero General Public License v3.0
1.02k stars 71 forks source link

Add Permalinks to Comments #272

Closed devadattas closed 4 months ago

devadattas commented 5 months ago

Description:

We need to add the functionality of permalinks to comments within the Vikunja application. This will allow users to directly link to specific comments, enhancing the usability and navigation of the comment section.

Acceptance Criteria:

  1. Each comment should have a unique permalink.
  2. The permalink should be easily accessible from the comment interface (e.g., a link icon next to each comment).
  3. Clicking on a permalink should navigate the user directly to the corresponding comment, highlighting it or bringing it into view.
  4. Permalinks should be shareable and retain functionality across different devices and sessions.

Technical Notes:

Additional Information: This feature request stems from user feedback indicating the difficulty in referencing specific comments in long threads. Implementing permalinks will significantly improve the user experience.

Benimautner commented 5 months ago

I'm guessing you're talking about the web frontend for vikunja? This repository is for the Android app, and we don't even have comment support yet.

You probably want to head there: https://kolaente.dev/vikunja/vikunja

@kolaente

kolaente commented 5 months ago

I've added an item to the backlog about this - for the web version.

devadattas commented 5 months ago

Isn't this https://github.com/go-vikunja/vikunja a mirror for https://kolaente.dev/vikunja/vikunja ?

kolaente commented 5 months ago

Yes.

devadattas commented 5 months ago

Wondering if I could add PRs to this repository?

kolaente commented 5 months ago

You mean here on GitHub? That is not possible unfortunately because the CI runs only on the Gitea instance. You can send a PR there.

Also check out our contribution guidelines.

devadattas commented 5 months ago

I have tried logging into https://kolaente.dev/vikunja/vikunja

But it won't let me login.

image

kolaente commented 5 months ago

I've enabled your account, you should be able to send a PR now.

We have a spam problem on the Gitea instance and the only thing which really works is manually enabling accounts.

devadattas commented 5 months ago

You said:

https://github.com/go-vikunja/vikunja/issues/272#issuecomment-2165803796

I've added an item to the backlog about this - for the web version.

Could you please point me to the ticket at https://kolaente.dev/ ?

devadattas commented 5 months ago

Please check https://kolaente.dev/vikunja/vikunja/issues/2441 and the corresponding PR at https://kolaente.dev/vikunja/vikunja/pulls/2442

kolaente commented 5 months ago

Could you please point me to the ticket at https://kolaente.dev/ ?

There's no issue on the Gitea instance, but a task here: https://my.vikunja.cloud/tasks/20650#share-auth-token=UrdhKPqumxDXUbYpEGJLSIyNTwAnbBzVlwdDpRbv

kolaente commented 4 months ago

Resolved in 5f9d0fe763dcbee3273e0f90b84aa35dca091f9d