search

go-vikunja / vikunja

Mirror of vikunja from https://code.vikunja.io/api
GNU Affero General Public License v3.0
1.02k stars 70 forks source link

Saving a project view throws error "G.update is not a function" #312

Closed lynnerup closed 2 months ago

lynnerup commented 3 months ago

Description

When saving any proejct view, the view is not saved, and you see an error saying "G.update is not a function".

As of writing, the error can be reproduced using "Project 1" in the demo site.

How to reproduce

  1. Create a new project.
  2. Go to the "Edit views" popup.
  3. Click the edit button for any view
  4. Click the Save button
  5. The view is not saved, and you see an error saying "G.update is not a function".

Vikunja Version

v0.24.1-43-ec2c2e74f0

Browser and version

Google Chrome Version 127.0.6533.120 (Officiel version) (64-bit)

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

image

image

JoaoVictorLouro commented 3 months ago

I quickly looked into the source code, it looks like it was a simple typo. Its trying to update by calling update on a CLASS and not on the class instance. should be fixable by simply changing ProjectViewService to projectViewService. file is ProjectSettingsViews.vue Maybe i can open a PR...

image
JoaoVictorLouro commented 3 months ago

Here is the PR: https://github.com/go-vikunja/vikunja/pull/318

Would be nice if someone could look into it!

kolaente commented 2 months ago

Fixed in https://github.com/go-vikunja/vikunja/commit/435cb2e7f753a1d8add6b4914890bf1ea93ab8c6, please check with the next unstable build (should be ready for deployment in ~45min, also on try).