Filters with invalid filter expressions are still created

Ma27 commented 1 week ago

Description

To reproduce:

Create a new saved filter with name "Foo"
Set the expression to syntax = error
When hitting the create button, you'll get an error that the expression is invalid and the create modal doesn't close.

However, a filter called Foo is created regardless. This means if it takes 5 attempts to produce a valid filter, I'll have 5 filters called Foo created.

I'd expect no filter to be created given the error.

Vikunja Version

whatever is on try.vikunja.io

Browser and version

No response

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

No response

kolaente commented 4 days ago

Fixed in bd3eab8c340c6b465ddb50bafa169aebc5d9de8d, please check with the next unstable build (should be ready for deployment in ~45min, also on try).

Ma27 commented 3 days ago

Looks correct now on try.vikunja.io, thanks!

Guess I'll just update my vikunja, using master anyways with the PRs from me on top and have regular backups just in case ;-)

go-vikunja / vikunja