Limit check for buckets seems broken

Ma27 commented 1 week ago

Description

I observed it multiple times that even though the amount of cards was well below the limit. After checking the task_buckets table, I found 201 entries with bucket_id 95 even though said bucket only has 58 entries currently.

After examining the list, I realized that there are also tasks that were

closed (even though the saved_filter has done = false)
archived projects (my expectation is that these are ignored by filters)
stuff that used to have the label that is required to belong to the filter

and probably more.

AFAIU the reason I get the correct amount of cards is because the filter is evaluated each time. If this code would also rely on said table, I'd probably get all 201 entries.

To me this pretty much looks like several write operations don't have an update event for task_buckets. Also, it would be pretty neat if a migration could clean this table up when the bug gets fixed.

Vikunja Version

0.24.4

Browser and version

No response

Can you reproduce the bug on the Vikunja demo site?

Please select

Screenshots

No response

kolaente commented 1 week ago

Does this happen only with filters?

Ma27 commented 1 week ago

I only observed it with filters so far, yes.

kolaente commented 2 hours ago

Does this happen only with bucket filters? I was unable to reproduce this with a saved filter and a manual kanban board.

Ma27 commented 1 hour ago

OK I'll do another reproduction attempt on a fresh installation here soon.

kolaente commented 1 hour ago

A fresh account from https://try.vikunja.io/demo-account-create/ might work as well.

go-vikunja / vikunja