go-vikunja / vikunja

Mirror of vikunja from https://code.vikunja.io/api
GNU Affero General Public License v3.0
773 stars 56 forks source link

Webhook missing response data (Docker Unstable) #98

Closed CyberTechArmor closed 7 months ago

CyberTechArmor commented 7 months ago

Description

Environment: Docker Frontend tag: unstable API tag: unstable Addition consideration: n8n and the Vikunja n8n community node

I updated to the unstable version to add the webhook functionality. I'm using n8n to test and connect the api integration. I was successfully able to create a webhook and trigger it.

Issue: the response data is empty, both params and query. I'm assuming that the triggered even should pass along some information, even if it's only the id of the event. The specific trigger: task.comment.created.

I attached the n8n response output image for reference. I did not see any other information from either the website or api docs (on the main website or my instance) other than creating/updating, meaning I did not find what the expected response output of a webhook should be (why I added to issues).

*Side note: Vikunja is an awesome project. It's incredibly fast, simple in design but extensive in its capabilities, consistent development and even integrations (like n8n). Just wanted express my appreciation, thank you for the hard work and dedication.

Vikunja Frontend Version

unstable

Vikunja API Version

unstable

Browser and version

Chrome Version 119.0.6045.200 (Official Build) (64-bit)

Can you reproduce the bug on the Vikunja demo site?

No

Screenshots

image

kolaente commented 7 months ago

Can you verify if this is a problem of n8n or the Webhook itself? (Adding a webhook for a webhook test provider should do the trick)

CyberTechArmor commented 7 months ago

I just checked using this webhook testing site: https://console.hookdeck.com/

I did get response data: image

I will check other n8n webhook options to see if I can pull in that data. If I'm able to identify it, I'll report back with the specific settings.

CyberTechArmor commented 7 months ago

All set, working as intended.

Just have to add the "raw" response body setting: image

Then have to set convert the binary to json: image image

I appreciate the quick response. I'm closing the issue. Thanks again

kolaente commented 7 months ago

I wonder if that might still be a problem of Vikunja? Maybe we're missing a json header or something like that. Do you have the same problem with the Vikunja n8n webhook trigger?

CyberTechArmor commented 7 months ago

Yeah, it's immediately being triggered and acknowledges the event, but there is no corresponding data. My guess would be that it's the same issue:

image image

kolaente commented 7 months ago

It looks like the json header was missing. I've added it in 57bd5aca804b99ef6dcca9178b0f70d3c354ffdc - can you check with the next unstable build if the n8n node works as expected?

CyberTechArmor commented 7 months ago

Looks like that resolved the issue:

image

Thank you for the update.