go-zeromq / zmq4

[WIP] Pure-Go implementation of ZeroMQ-4
BSD 3-Clause "New" or "Revised" License
344 stars 57 forks source link

zmq4: make number of retries for dial configurable #126

Closed thielepaul closed 2 years ago

thielepaul commented 2 years ago

Fixes #85

codecov[bot] commented 2 years ago

Codecov Report

Merging #126 (03b1695) into main (04c84de) will increase coverage by 0.54%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   67.63%   68.18%   +0.54%     
==========================================
  Files          29       29              
  Lines        1817     1820       +3     
==========================================
+ Hits         1229     1241      +12     
+ Misses        488      480       -8     
+ Partials      100       99       -1     
Impacted Files Coverage Δ
options.go 83.33% <100.00%> (+23.33%) :arrow_up:
socket.go 83.90% <100.00%> (+0.67%) :arrow_up:
cxx_zmq4_compat.go 42.35% <0.00%> (-4.71%) :arrow_down:
rep.go 76.69% <0.00%> (+7.51%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04c84de...03b1695. Read the comment docs.

thielepaul commented 2 years ago

I just fixed the test

sbinet commented 2 years ago

please rebase off the latest main, thanks.

thielepaul commented 2 years ago

@sbinet the ipc-crouter-cdealer test always fails for me, and I cannot find the reason. Would it be ok for you if we skip the test for now, or do you have any idea, how my changes could be related to the test fail?

sbinet commented 2 years ago

yeah, it's been flaky (the whole IPC transport actually). I've disabled it: https://github.com/go-zeromq/zmq4/pull/129

thielepaul commented 2 years ago

yeah, it's been flaky (the whole IPC transport actually). I've disabled it: #129

thanks, but this commit disables inproc-crouter-cdealer and not ipc-crouter-cdealer ;)