Closed thielepaul closed 2 years ago
I tested it for pub and sub sockets: for pub sockets it works fine, for sub socket I have the problem described in #116
Merging #127 (a2090eb) into main (ae18bc0) will decrease coverage by
0.00%
. The diff coverage is100.00%
.:exclamation: Current head a2090eb differs from pull request most recent head 978883a. Consider uploading reports for the commit 978883a to get more accurate results
@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 67.58% 67.58% -0.01%
==========================================
Files 29 29
Lines 1820 1823 +3
==========================================
+ Hits 1230 1232 +2
- Misses 490 491 +1
Partials 100 100
Impacted Files | Coverage Δ | |
---|---|---|
options.go | 66.66% <100.00%> (-16.67%) |
:arrow_down: |
socket.go | 84.18% <100.00%> (+0.27%) |
:arrow_up: |
internal/inproc/inproc.go | 72.15% <0.00%> (+1.26%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ae18bc0...978883a. Read the comment docs.
please rebase off the latest main
, thanks.
please rebase off the latest main
, thanks.
(yeah, stacked PRs are a bit of a pain on github.)
please rebase off the latest
main
, thanks. (yeah, stacked PRs are a bit of a pain on github.)
No problem, thank you for taking the time to review my PRs!
last remaining nit-picks. looking good :)
thx, I applied them
I have not tested this yet, it's meant as discussion base for #124
Fixes #124