go-zeromq / zmq4

[WIP] Pure-Go implementation of ZeroMQ-4
BSD 3-Clause "New" or "Revised" License
341 stars 56 forks source link

zmq4: resend subscriptions in socket.addConn #128

Closed thielepaul closed 2 years ago

thielepaul commented 2 years ago

Fixes #116

codecov[bot] commented 2 years ago

Codecov Report

Merging #128 (e092dc6) into main (16d169c) will decrease coverage by 0.11%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   67.53%   67.41%   -0.12%     
==========================================
  Files          29       29              
  Lines        1814     1817       +3     
==========================================
  Hits         1225     1225              
- Misses        489      491       +2     
- Partials      100      101       +1     
Impacted Files Coverage Δ
socket.go 83.23% <100.00%> (+0.19%) :arrow_up:
sub.go 76.92% <100.00%> (+0.45%) :arrow_up:
conn.go 55.17% <0.00%> (-1.15%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16d169c...e092dc6. Read the comment docs.

thielepaul commented 2 years ago

@sbinet I don't understand how the coverage in conn.go is reduced by my changes, do you understand what is going on there?

sbinet commented 2 years ago

code coverage (with codecov) can be a bit flaky, in my experience.

sbinet commented 2 years ago

needs https://github.com/go-zeromq/license/pull/12

sbinet commented 2 years ago

thanks again (and welcome!)