Closed bartekpacia closed 2 years ago
Base: 67.71% // Head: 67.54% // Decreases project coverage by -0.16%
:warning:
Coverage data is based on head (
63f5ffd
) compared to base (217f26c
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@sbinet Sure, will do.
Also could you answer my question?
I called Socket.Listen() in my sub, and Socket.Dial() on my pub. It had to be reversed to work. I thought docs could clarify this. Also, I think it a bit confusing that my publisher calls Listen(), as if it was listening for messages. Why was this named like this?
I called Socket.Listen() in my sub, and Socket.Dial() on my pub. It had to be reversed to work. I thought docs could clarify this. Also, I think it a bit confusing that my publisher calls Listen(), as if it was listening for messages. Why was this named like this?
the Dial/Listen
pair is the usual Go vocabulary.
I felt compelled to follow this naming convention for a pure-Go package.
another way of describing the pub/sub network, if you will, could be:
thanks for the PR :)
another way of describing the pub/sub network, if you will, could be:
- a publisher listens/waits for new subscribers to subscribe to its feed(s)/topic(s)
- a subscriber dials/connects to a publisher and subscribes to topics.
I didn't think about it this way. It makes sense now!
the Dial/Listen pair is the usual Go vocabulary. I felt compelled to follow this naming convention for a pure-Go package.
I agree with this choice, thanks for following Go idioms in this awesome module :)
I've lost some time when trying to build a very simple pub-sub (without looking at the examples).
I called
Socket.Listen()
in my sub, andSocket.Dial()
on my pub. It had to be reversed to work. I thought docs could clarify this.Also, I think it a bit confusing that my publisher calls
Listen()
, as if it was listening for messages. Why was this named like this?