Closed encse closed 1 year ago
Patch coverage: 71.42%
and project coverage change: -0.22%
:warning:
Comparison is base (
bd7e871
) 67.63% compared to head (099cec7
) 67.42%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
(apologies for the belated answer: holidays and the backlog from work...)
thanks for the PR.
could you send another PR against https://github.com/go-zeromq/license adding yourself to the AUTHORS
and/or CONTRIBUTORS
files ?
(then I'll merge that one. it will take less than a month from side :P)
Hey, thanks for your time. I added myself in this PR: https://github.com/go-zeromq/license/pull/16
thanks a lot.
I have found a race condition in the ctx cancellation in
repWriter
.Added a test which reproduces the issue with a possible fix.
I don't quite understand why dont we use
ctx
in the write routine, see my second commit about that.