Closed egorse closed 11 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
e16dc3e
) 68.51% compared to head (2bf3109
) 68.07%.
Files | Patch % | Lines |
---|---|---|
rep.go | 50.00% | 1 Missing :warning: |
req.go | 50.00% | 1 Missing :warning: |
socket.go | 80.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
we don't exercize the whole
errorgrp.Group2.Go
code. we could probably try to make sure we still get the context error when it expires during the execution off
. (probably with a 2-level handshake where thecancel()
happens when we are suref
is being executed)
This is sort of odd - I had impression that only block execution of f if context is already cancelled (i.e. if the eg has limits on number of executable functions and parent context got cancelled prior next f in eg started). I will check it and update PR (include others suggestions)
update: Test case was missing
I think its ready for next review cycle. Please comment
Please take a look. Still not sure how well it is on implicit errgroup.Group initialization
Dough - original init() was nicer for codecov. Will wait for your comments
Add internal/errorgrp package to support cancellable error groups Add tests for push/pull timeout