search

go-zookeeper / zk

Native ZooKeeper client for Go
BSD 3-Clause "New" or "Revised" License
512 stars 130 forks source link

devcontainer, would like to setup a devcontainer #111

Closed jeffbean closed 1 year ago

jeffbean commented 1 year ago

for integration testing to be more deterministic.

https://github.com/golang/go/issues/12868#issuecomment-283176161

One code change that i think is overall safe.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.59 :warning:

Comparison is base (abd6db4) 76.78% compared to head (3996724) 76.19%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #111 +/- ## ========================================== - Coverage 76.78% 76.19% -0.59% ========================================== Files 7 7 Lines 1193 1193 ========================================== - Hits 916 909 -7 - Misses 189 193 +4 - Partials 88 91 +3 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/go-zookeeper/zk/pull/111/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-zookeeper)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jeffbean commented 1 year ago

@yarikk or @pmazzini can I get owner membership for the organization?

pmazzini commented 1 year ago

Done