Open PapaCharlie opened 8 months ago
Attention: Patch coverage is 69.06475%
with 129 lines
in your changes are missing coverage. Please review.
Project coverage is 75.00%. Comparing base (
c5e730e
) to head (d59ad1b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It may be more convenient to look at these changes sequentially:
zk.Event
which is set when the event is received. Useful for tracking how long it took to get to a specific event (especially relevant when consuming from persistent watches).log/slog
instead of providing a custom logger interface. Change theDialer
interface to something that's trivially implemented bytls.Dialer
andnet.Dialer
, making it much easier to provide client certificates when connecting to ZK. Improve the error handling by returning stacked errors. Especially convenient when trying to understand why a specific connection was closed. Note that this PR would require a new major version as it does introduce backwards incompatible changes.HostProvider
that more closely matches the Java client's implementation, i.e. it resolves the address on-demand rather than once statically. This is also backwards incompatible as it changes the semantics of theHostProvider
implementation to support sleeping after attempting to connect to the address returned byNext
, rather than before.