Closed jeffbean closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.50%. Comparing base (
6131812
) to head (b61590a
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Based on the PR https://github.com/go-zookeeper/zk/pull/125 that shows the issue at hand. The bug was in the CreateContainer and CreateTTL methods.
For others that may face new errors:
path, err := c.CreateContainer("/container-node", []byte("foo"), zk.FlagTTL, zk.WorldACL(zk.PermAll))
if err != nil {
log.Fatal(err)
}
// old: would not error, and create a Container znode
// new: will return an error that this is not a TTL operation and not create a znode
BREAKING Client behavior: since this proposes a new parsing of the Create flag integer this will break clients if they rely on CreateContainer as it was creating znodes that may not have been containers.
Changes: