Open bmermet opened 3 years ago
Merging #63 (7f25d2f) into master (8866d76) will increase coverage by
0.52%
. The diff coverage is100.00%
.:exclamation: Current head 7f25d2f differs from pull request most recent head 083a313. Consider uploading reports for the commit 083a313 to get more accurate results
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 75.27% 75.79% +0.52%
==========================================
Files 7 7
Lines 1189 1194 +5
==========================================
+ Hits 895 905 +10
+ Misses 202 198 -4
+ Partials 92 91 -1
Impacted Files | Coverage Δ | |
---|---|---|
conn.go | 72.58% <100.00%> (+1.00%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8866d76...083a313. Read the comment docs.
Hi @nemith, Would you be able to have another look at this PR? Let me know if there are other things I can improve.
@nemith is there something blocking this change from being reviewed? Any guidance on how to get this PR moving forward would be much appreciated.
This PR adds a way to read the session id and session password from an established session and to provide them as argument when creating a new connection, allowing to recover an existing session. (This mimicks what the java Zookeeper allows: https://zookeeper.apache.org/doc/r3.3.3/api/org/apache/zookeeper/ZooKeeper.html)
A possible use case for this is to store these values in persistent storage and re-establish a session after a process restart.
Operations to get and set
passwd
are implemented with atomic operations on an unsafe pointer to be consistent with the atomic operations used forsessionID
but I'm happy to change the PR to use a lock instead if that's preferable.I have also made a small change to the
waitForSession
helper that I think is consistent with what the function tries to achieve.Locally all the tests are passing except for
TestSetWatchers
but it also fails on master with the following error: