search

go2sh / cmake-integration-vscode

CMake Server Interface for VSCode.
https://go2sh.github.io/cmake-integration-vscode/
Other
19 stars 11 forks source link

Configure workspace/folder commands are not prefixed with cmake #26

Closed hriekehof closed 5 years ago

hriekehof commented 5 years ago

In the Shortcut overview i see that the commands to configure a workspace or a folder are not prefixed with CMake.

image

It would be nice to have the same prefix there to be sure that with the Configure means a CMake configure.

mmanyen commented 5 years ago

I have updated package.json for this change.

I completely noob to github, so I don't know how to create a branch/pull request so I attach the changed file here...

package.zip

go2sh commented 5 years ago

Ah. Initially, I thought it would be nice to prefix the operations with the area they are used for, e.g. Build for build related tasks, Configure -> for configure related task, etc. But I don't mind. Do you think it would be better with everything having the CMake prefix? @mmanyen @hriekehof

hriekehof commented 5 years ago

personally i would prefer to prefix all commands with CMake. In VScode you can end up with alot of different extensions which all introduce their commands etc. And Configure for example is surely something which occurs often.

Another thing is that i use the command mode with strg + shift + p alot. When i then search for CMake i find all commands which are possible to use and i'm also sure that they belong to CMake. When i search for Configure i also find other configure commands from other extensions and have to read more lines to be sure to select the CMake configure project folder.

But as i said this is surly a matter of taste but i would prefer a prefix for all available commands

mmanyen commented 5 years ago

I have been running with the above change and prefer it greatly.

go2sh commented 5 years ago

I'll change it. :-)