go2sh / cmake-integration-vscode

CMake Server Interface for VSCode.
https://go2sh.github.io/cmake-integration-vscode/
Other
19 stars 11 forks source link

package-lock.json not commited #40

Closed SoftwareApe closed 5 years ago

SoftwareApe commented 5 years ago

Running npm install shows a warning that package-lock.json should be committed. This way every developer has the same dependency tree.

https://stackoverflow.com/a/44210813/3387223

go2sh commented 5 years ago

I can do that. Personally, I use yarn, so only the yarn lock file is committed right now. ;-)

SoftwareApe commented 5 years ago

Ah, didn't notice that, sorry!

go2sh commented 5 years ago

I'll use yarn for most of my projects so I'll keep it that way and close this issue. I do not know any way to keep both in sync. But I'll create a CONTRIBUTING.md file with the required steps for developers. I hope it's okay that way for you.