search

go4retro / tcpser

Hayes modem emulator application
106 stars 30 forks source link

missing { #11

Closed mausalimi closed 3 years ago

mausalimi commented 3 years ago

last commit missis the bracket.

go4retro commented 3 years ago

Can you provide more clarity (what line?) It builds fine for me.

mausalimi commented 3 years ago

well only a single line changed, so it is

line 56

in ipc.c

also there's a bunch of ugly (although harmless) compiler warnings, at least in cygwin

go4retro commented 3 years ago

sync and compile again and see if the problems are addressed. I did have some uncommitted fixes that I just uploaded, so perhaps I fixed the '{' and just didn't get it committed. Still, I am compiling on cygwin here with GCC 10.2.0, and there's currently only 1 warning (in getcmd.c).

mausalimi commented 3 years ago

ah, that looks really different now, it does compile out of the box.

however, i get 9 warnings in getcmd.c, all of the same type "Warning array subscript has type 'char' [-Wchar-subscripts]"

but this is in an ancient cygwin, usually i use msys... so i guess it's all fine.

go4retro commented 3 years ago

I'd grab a more recent cygwin (mine's from a few months ago), as only 1 should be showing up. Glad to hear it is now resolved.