go4retro / tcpser

Hayes modem emulator application
106 stars 30 forks source link

The latest version of tcpser for windows #23

Open radius75 opened 1 year ago

radius75 commented 1 year ago

The last version is 1.1.5_alpha for windows? Is a newer version ready, and can you please compile it for Windows?

-- In addition to this 1.1.5_alpha I see in the master branch 1.1.5 and 1.1.rc2, hmm which is the latest?

go4retro commented 1 year ago

1.1.4 is the latest release. The current master branch includes 2 Linux fixes, but nothing for Windows.

1.1.rc2 is older than 1.1.4, and I don't see 1.1.5 in the git tags. 1.1.5_alpha is just the current version.h string for any test compiles I send out, but is not a proper tag as yet. If you can provide a link to what you are seeing, I will check.

radius75 commented 1 year ago

I found them by looking through the commits history. :) Version 1.1.4 also somewhere, now I can't find it. On the start screen is version 1.1.5_alpha (current master branch) and in downloads 1.1.rc2 (described as release 1.1.4) This is how they identify themselves with the -V command

a0e9708 -1.1.5_alpha b1d5689 -1.1.5_alpha 8950042 -1.1.5 8c0580f -1.1.rc2 obraz

1.1.5_alpha obraz

1.1.rc2 obraz

radius75 commented 1 year ago

1.1.4 I found here 054a8ff

The version described as 1.1.4 (in Tags/Releases) reports itself as 1.1.rc2 I feel a bit confused :)

go4retro commented 1 year ago

In my haste, I sometimes don't recompile the Windows binary before pushing the repo. I keep meaning to set up actions and a docker instance to do it automatically on push, but have not gotten it going yet.

The version in 1.1.4 release should have reported as 1.1.4. I'll create an official 1.1.5 release that has the right version string.

But, to clear up things:

With 1.1.rc2, I added in -V version flag, but I initially hard coded the version: https://github.com/go4retro/tcpser/commit/8c0580f4f9944f51134ae40383880382ec4e6885.

I then created a 1.1.3 with a better way to manage the changing version info: https://github.com/go4retro/tcpser/commit/1d8967d456872ec1790b8f30bd89051354b5cb69

But, I did not recompile the Windows binary in the last commit. That's why it said 1.1.rc2.

For some reason, i thought there was already an 1.1.rc3, so I quickly modified the source to be 1.1.4: https://github.com/go4retro/tcpser/commit/234ccfde0bb6a874c353c0cdca0fa0ca76c5cca3. Still no recompile of the Windows binary

I then created the 1.1.4 release.

Then, I started with the 1.1.5 code changes, but it looks like my first commit forgot to add the _alpha, which I quickly fixed.

Jim

radius75 commented 1 year ago

Thanks. I think I got it. ;) In that case, I'm waiting for official 1.1.5 and I'm using Tagged 1.1.4 for now :) Regards Krzysztof

radius75 commented 1 year ago

I'd like to ask you one thing. Has the Vice bug mentioned in 054a8ff been fixed to your knowledge?