search

goToMain / libosdp

Implementation of IEC 60839-11-5 OSDP (Open Supervised Device Protocol); provides a C library with support for C++, Rust and Python3
https://libosdp.sidcha.dev
Apache License 2.0
128 stars 69 forks source link

Feature/gcc warning errors #142

Closed badevos closed 8 months ago

badevos commented 8 months ago

Hi,

I'm trying to integrate your library into another project using gcc 8.4.0 with '-Werror'. This gives some small issues. Would it be possible to integrate my changes?

This affects both the library as items into your submodule 'utils'. I create a separate pull request for that.

Logically you can skip the changes to link to my fork, but this allows me to do a full integration myself.

In case you accept my changes I can safely use the upstream version.

Let me know your thoughts.

Thanks in advance.

Kr, Bart.

sidcha commented 8 months ago

Hey! PRs are most welcome and I will be happy to merge any patch that fixes issues in any platform (which looks to be the case here).

In this case, can you please create separate PR in utils submodule first and then update this PR with the submodule bump commit here after the utils changes are merged.