goToMain / libosdp

Implementation of IEC 60839-11-5 OSDP (Open Supervised Device Protocol); provides a C library with support for C++, Rust and Python3
https://libosdp.sidcha.dev
Apache License 2.0
138 stars 71 forks source link

incompatibility with secure channel keys? #52

Closed rsgmodelworks closed 3 years ago

rsgmodelworks commented 3 years ago

we are getting reports this code is not compatible with other OSDP implementations because it uses "MK" key derivation, which is not used in modern OSDP.

sidcha commented 3 years ago

@rsgmodelworks, thanks for looking into this.

this code is not compatible with other OSDP implementations

This is not accurate. Reading the latest IEC spec, I believe this library should work as the "MK" key derivation is not deprecated yet (correct me if I am wrong here).

This project was developed with v2.1.6 of the OSDP specification which does not dissuade the use of a shared master key to setup the SCBKs. That said, I'll add this topic to a list things I need to fix before bumping the OSDP supported version.

sidcha commented 3 years ago

Closing this issue as it will be tracked as part of #53.