goToMain / libosdp

Implementation of IEC 60839-11-5 OSDP (Open Supervised Device Protocol); provides a C library with support for C++, Rust and Python3
https://libosdp.sidcha.dev
Apache License 2.0
138 stars 71 forks source link

OSDP CP init should make sure that the SCBKs are different and non-zero. #57

Closed sidcha closed 1 year ago

sidcha commented 3 years ago

Now the application can setup a CP with different SCBKs for each PD without passing a master key. But an ignorant programmer can pass the same SCBK buffer to all the PDs or worse, pass all zeros.

LibOSDP should do some preliminary checks on SCBK we receive from the user.

This issue was revealed from PR: #56

sidcha commented 1 year ago

This isn't adding much value. Closing.