Closed Tomcat-Engineering closed 2 years ago
Sorry about that. That is indeed wrong behaviour. Let me take a quick look.
@Tomcat-Engineering, this issue should be resolved now. Please check and let me know.
Thanks for the super-quick fix. Unfortunately I don't have any OSDP devices here right now so I'm unable to test it, but it looks like it should work! Many thanks.
Describe the bug
Here is how you set the state of the LEDs temporarily:
However, this command also sets the state of the LEDs temporarily:
This is because the code is just looking for the existence of the
temporary
flag, not its value. Not sure whether this is intentional but it definitely caught me out and took me a couple of hours to figure out!Expected behavior
Setting
"temporary": False
in an LED command updates the permanent state of the LEDs, not the temporary state.Observed behavior
Setting
"temporary": False
in an LED command updates the temporary state of the LEDs, not the permanent state.