search

goToMain / libosdp

Implementation of IEC 60839-11-5 OSDP (Open Supervised Device Protocol); provides a C library with support for C++, Rust and Python3
https://libosdp.sidcha.dev
Apache License 2.0
137 stars 71 forks source link

Symbol pd_commnand_callback_t contains spelling typo #83

Closed pcpro178 closed 2 years ago

pcpro178 commented 2 years ago

Symbol pd_commnand_callback_t needs to be renamed to pd_command_callback_t to fix spelling typo.

pcpro178 commented 2 years ago

I already have a fix for this, but I'm unable to assign myself to the ticket. When I try to push the branch, it gives me a permission denied error.

$ git push --set-upstream origin symbol_typo_fix
remote: Permission to goToMain/libosdp.git denied to pcpro178.
fatal: unable to access 'https://github.com/goToMain/libosdp/': The requested URL returned error: 403
sidcha commented 2 years ago

Hi @pcpro178, you are trying to push to the project directly while you should be creating a pull-request to get your change merged.

You can read all about this here. TL;DR, create a fork, push your changes to it, then come here and click on the create pull request button.

omnisci3nce commented 2 years ago

Hah, I was about to point this out too.

sidcha commented 2 years ago

I'm going to fix this myself and add you as the reporter.

sidcha commented 2 years ago

Fixed in a7913ba5