goToMain / libosdp

Implementation of IEC 60839-11-5 OSDP (Open Supervised Device Protocol); provides a C library with support for C++, Rust and Python3
https://libosdp.sidcha.dev
Apache License 2.0
130 stars 69 forks source link

Incorrect command ID to instruct a PD to abort on current operation. #93

Closed surendersampath closed 1 year ago

surendersampath commented 1 year ago

Describe the bug Incorrect command ID to instruct a PD to abort on current operation (File Transfer for example).

Expected behavior

CP device to send abort command with osdp_ABORTCOMMAND ID 0xA2. As per OSDP V2.2.

image

Observed behavior Library is sending 7A which is osdp_FTSTAT. This is not per OSDP V2.2.

image

Additional context

The context is OTA file transfer between CP and PD. CP wants to abort the file transfer.

sidcha commented 1 year ago

@surendersampath, Thanks for reporting the issue, fixed now.