goToMain / libosdp

Implementation of IEC 60839-11-5 OSDP (Open Supervised Device Protocol); provides a C library with support for C++, Rust and Python3
https://libosdp.sidcha.dev
Apache License 2.0
130 stars 69 forks source link

pd_translate_event() missing support for OSDP_EVENT_MFGREP #96

Closed surendersampath closed 1 year ago

surendersampath commented 1 year ago

Describe the bug PD is trying to notify OSDP_EVENT_MFGREP to CP. But it does not go through. As the library currently supports REPLY_MFGREP

Expected behavior Handle case OSDP_EVENT_MFGREP in function pd_translate_event()

Observed behavior Missing case OSDP_EVENT_MFGREP in function pd_translate_event()

Additional context Not Applicable.

A Comprehensive Log file Dequeue event fails when it tries to notify REPLY_MFGREP event. image

sidcha commented 1 year ago

Ah, yes, seems to be a miss. Will fix it now thanks for reporting it.