search

goaaats / Dalamud.FullscreenCutscenes

12 stars 8 forks source link

1.0.0.3 Update for Dawntrail and API10 #7

Closed MapleHinata closed 2 months ago

MapleHinata commented 3 months ago

Add the required changes for API10 and fixes the plugin for use with 7.0. The original function got inlined with it's bigger parent in Dawntrail, thankfully, whatever object this function belongs to, contained a toggle for letterboxing. (Thanks to @notnite for figuring that out).

Seems to behave just like the plugin did prior to 7.0.

(Random sample picture below) FINAL FANTASY XIV Online 2024-07-05 22ː04ː11

xKillerbees commented 3 months ago

Working great!

LiamMoseley commented 3 months ago

This seems to do the job, well done. Hope to see this merged into the main branch shortly.

io-dream commented 3 months ago

This actually seems to cause intense flickering on startup and maybe in other scenarios but I have not kept it on long enough to check.

Appeared very good at first glance (it does what it says on the tin), but the flickering on startup is about full contrast for 1 frame, 80% contrast next frame. full, 80%, repeat. If you have this enabled and Dalamud injected on startup 0ms then you may see the same behavior.

goaaats commented 3 months ago

It's possible that something is trying to set that flag every frame outside of the hook, causing the flickering. A good way to find out would be to set a data breakpoint in CE.

MapleHinata commented 3 months ago

I mentioned it on the Discord, but for transparency sake: I could not reproduce the flickering on the title screen, on my end, the game only wrote to that memory address twice on the start up sequence, once to set the flag, followed by another write to remove the flag, and that was it. (Until the client wrote some other flags to that bit field on the "Now loading" screen during the first load after logging in)

I added a condition to only change this flag if the Player is in a cutscene, hopefully it fixed edge cases like that?

io-dream commented 3 months ago

Also mentioned on Discord but here for posterity sake:

The most recent change seemed to fix it and I no longer have this issue. All is well and the flickering is gone :)

I tested on startup multiple times, tested watching a cutscene as soon as possible logging in multiple times, and tested watching a cutscene multiple times after being in game for a while.

VegnaChaos commented 2 months ago

How can i download this update? or add the URL to Dalamud?