goaaats / Dalamud.RichPresence

Discord Rich Presence for Dalamud
13 stars 19 forks source link

API 7 bump #15

Open reiichi001 opened 2 years ago

reiichi001 commented 2 years ago
jacksonrakena commented 2 years ago

@reiichi001 would it be worth updating all the dependencies in this pull request? For some reason the RPC plugin randomly doesn't work for a subset of users and updating the dependencies (I believe it's XivCommon that is the culprit) fixes that issue.

Updating the dependencies fixed this issue with null data.

I fixed all those issues in my fork Abyssal.RichPresence but my fork has diverged quite a bit (I did some additional fixes with DiscordRPC, which apparently fails to connect sometimes because of a JSON parsing issue) so it might be worth just updating this PR.

Updating dependencies would fix #17 and #12, I believe.

reiichi001 commented 2 years ago

@jacksonrakena, we're already using the latest stable version of the discord-rpc-csharp package. If you want to pull their current master, that should be done via submoduling, not pulling in the source, building it in debug, and then referencing the DLL. See https://github.com/reiichi001/Dalamud.RichPresence/tree/submodule-discordrpc as an example of how to do this.

While I can definitely update the other dependencies like XivCommon and push a new build for that, I'm hesitant to switch to submoduling the RPC library as we're then basically pulling a nonrelease from a random snapshot in time that could have bugs or other WIP code. I'd personally want to wait for an updated NuGet package, or at a minimum, a tagged release which could then be submoduled.

jacksonrakena commented 2 years ago

@jacksonrakena, we're already using the latest stable version of the discord-rpc-csharp package. If you want to pull their current master, that should be done via submoduling, not pulling in the source, building it in debug, and then referencing the DLL. See https://github.com/reiichi001/Dalamud.RichPresence/tree/submodule-discordrpc as an example of how to do this.

While I can definitely update the other dependencies like XivCommon and push a new build for that, I'm hesitant to switch to submoduling the RPC library as we're then basically pulling a nonrelease from a random snapshot in time that could have bugs or other WIP code. I'd personally want to wait for an updated NuGet package, or at a minimum, a tagged release which could then be submoduled.

@reiichi001 Ah yes, I should’ve made it clear that I wasn’t intending to PR from my fork, the pulling was just a quick hack to see if that was the issue.

I filed an issue in DiscordRPC so hopefully it is fixed and another NuGet release made.

jacksonrakena commented 2 years ago

@reiichi001 DiscordRPC just patched the serialization error and published a release (1.1.1.14), if you want to consider updating? https://www.nuget.org/packages/DiscordRichPresence/