Add support for Windows releases

liamdawson commented 2 years ago

Based on https://github.com/goatcorp/FFXIVQuickLauncher/pull/437#issuecomment-932833094, I figured there was an appetite for Windows builds.

Changes

Update flutter_secure_storage to 5.0.2 (introducing Windows support)
Add a Windows flutter target
Hide the QR code scanner on the "Set-Up OTP" page
- Not supported on Windows at this time
Show the App Bar on the QR code scanner page on Windows
- No way to cancel out to navigate back, otherwise
Make the logo flex (so it doesn't hide the bottom controls if the window is too wide)
Add a Powershell script to prepare Windows releases (Powershell due to built-in archiving support)

Notes/Discussion

I feel like we could do a lot for the UI on Windows, but I didn't want to introduce potentially unwelcome changes in this PR
How should OTP setup work on Windows in the longer term?
Should the IP address default to 127.0.0.1 on Windows? I feel like that would avoid "it's not working" messages in future
Sounds like we're in somewhat unsupported territory - the Flutter docs note:

We don’t recommend releasing a desktop application until desktop support is stable
I've only tried this on Windows 10, and only on the same machine I built the app on

Screenshots

liamdawson commented 2 years ago

For those who're brave enough to try it, here's a release zip built from ec05a162b6faa375c1d6803efea069edc47b8e89.

xl_otpsend-windows.ec05a16.zip

alphaONE2 commented 2 years ago

This works just fine on my Windows 11 box.

mkolassa commented 2 years ago

Tested as working on my Windows 11 desktop as well.

Pilzinsel64 commented 2 years ago

Works fine, really really nice! 👌 The only thing is that "Close after sent" doesn't work. But that's ok as it's a first test build and how different Android and Windows works at this point.

liamdawson commented 2 years ago

@Pilzinsel64 looks like there's no easy and clean way to accomplish that. I'll try doing an easy and dirty way to do it, and will otherwise fall back to taking the option out entirely (if it's not going to work).

Pilzinsel64 commented 2 years ago

@liamdawson Alright! 👍 As long as the process get closed, it's alright. Otherwise, just get rid of that option (like you did with the QR code scanner) sounds ok for here, I guess.

liamdawson commented 2 years ago

Release zip from f39ccab, fixes auto-close on my machine. Guess the queue times on Tonberry have some advantages 😅

xl_otpsend-windows.f39ccab.zip

Pilzinsel64 commented 2 years ago

That's really a simple fix. 😁 But works well! 👍

mkolassa commented 2 years ago

Looks like Flutter has added stable Windows support as of a few days ago.

goaaats / xl-authenticator