search

goadapp / goad

Goad is an AWS Lambda powered, highly distributed, load testing tool
https://goad.io
MIT License
1.88k stars 190 forks source link

Goad is not vendorable. #32

Open nxvl opened 8 years ago

nxvl commented 8 years ago

When using go as a dependency and vendoring it the following errors appears in the project:

vendor/github.com/goadapp/goad/infrastructure/infrastructure.go:49: undefined: Asset

This is related to the bin-data pre-requisite on build time, which needed and result files are ignored in .gitignore, thus not copied over to vendor/

jcxplorer commented 8 years ago

@nxvl Do you have any suggestions on how to fix this? Would having the bin-data files in the repo be the only solution?

nxvl commented 8 years ago

What i ended up doing was generating infrastructure/bindata.go on the goad repository, copied it over to the vendor/ path it belongs and remove it from the .gitignore file copied over by godeps. Maybe there is an easier way, i'm fairly new to go TBH.

zeph commented 7 years ago

@cwaltken-edrans please review it when u have time

cwaltken-edrans commented 7 years ago

Goad is not vendor-able right now due to the dependency on go-bindata bundling the lambda-function as an asset into the goad binary. Resolving this requires a change in the build and deploy/bundling process. Basically the lambda-function of the default runner needs to be included as a separate asset for this to be working. Goad was not designed to be used as a library, but we could get there in the near future.

gserra-olx commented 7 years ago

@nxvl is it something u might want/can contribute a patch eventually?

nxvl commented 7 years ago

@gserra-olx at this point we already ditched goad from our project, so i'm afraid i won't be able to properly tests it.