search

goadesign / goa

🌟 Goa: Elevate Go API development! 🚀 Streamlined design, automatic code generation, and seamless HTTP/gRPC support. ✨
https://goa.design
MIT License
5.69k stars 560 forks source link

Remove generation of unnecessary view types. #3568

Closed raphael closed 3 months ago

tchssk commented 3 months ago

Something doesn't seem right with this fix. My application doesn't build anymore in v3.18.1. Maybe We should reconsider #3567 and #3568. @raphael

raphael commented 3 months ago

Are you able to put together a repro that causes the issue?

tchssk commented 3 months ago

Could you upgrade examples? I triedi it locally and the multipart example failed in lint.

Making in ./multipart...
go: upgraded goa.design/goa/v3 v3.18.0 => v3.18.1
GENERATING CODE...      
gen/http/cli/resume/cli.go
gen/http/openapi.json  
gen/http/openapi.yaml
gen/http/openapi3.json
gen/http/openapi3.yaml
gen/http/resume/client/cli.go
gen/http/resume/client/client.go
gen/http/resume/client/encode_decode.go
gen/http/resume/client/paths.go
gen/http/resume/client/types.go
gen/http/resume/server/encode_decode.go
gen/http/resume/server/paths.go
gen/http/resume/server/server.go
gen/http/resume/server/types.go
gen/resume/client.go
gen/resume/endpoints.go
gen/resume/service.go
gen/resume/views/view.go

LINTING CODE...
-: # goa.design/examples/multipart/gen/resume/views
gen/resume/views/view.go:36:16: undefined: Experience
gen/resume/views/view.go:38:15: undefined: Education
gen/resume/views/view.go:109:15: undefined: ValidateExperience
gen/resume/views/view.go:116:15: undefined: ValidateEducation (compile)
^ - staticcheck errors!

make[1]: *** [lint] Error 1
make: *** [all] Error 1
raphael commented 3 months ago

Ohh the release for examples failed and I missed that. Looking into it - thanks for bringing this up!

raphael commented 3 months ago

I think this fixes it: https://github.com/goadesign/goa/pull/3569

tchssk commented 3 months ago

It's fixed. Thank you for the quick response!