goadesign / model

Create your software architecture models and diagrams in Go.
MIT License
332 stars 19 forks source link

Add property order to mdl.ViewProps #657

Closed beffge closed 3 months ago

beffge commented 3 months ago

Like discussed in https://github.com/goadesign/model/issues/655

beffge commented 3 months ago

Ready to merge when you are @raphael 😇

raphael commented 3 months ago

Thank you! Looks like the output of goimports -l changes the file which is not supposed to happen (that's why the build fails). Maybe try formatting the file locally and see if anything changes? You can also run make lint locally to reproduce the problem.

beffge commented 3 months ago

To be honest, I don't know what I did differently 🤷 Nevertheless, we're green now 😉 Maybe squash an merge to "hide" some of the commits 😇

raphael commented 3 months ago

Merged, thank you!

beffge commented 2 months ago

Hey @raphael , would it be ok to release a new version?

raphael commented 2 months ago

Just released v1.9.2, thank you for the contribution!