goalapi / documentation

A documentation for GoalAPI.com HTTP API
http://goalapi.com
0 stars 1 forks source link

Property matchday on Match object has different value types #4

Open adedayo09 opened 7 years ago

adedayo09 commented 7 years ago

When downloading matches, the property matchday is either of type String e.g. "Round 12" or type Int e.g. 12. I believe this should be kept consistent as it causes parsing errors on client side otherwise.

Example:

{
        "id": "87261667f928ad0a2078b8c35ab02f43",
        "begin_time": {
            "date_time": "2016-11-19T12:30:00+00:00",
            "timestamp": 1479558600
        },
        "status": {
            "status": "finished",
            "score": [
                1,
                1
            ],
            "finished_after": "2T"
        },
        "tournament": {
            "id": "eng_pl",
            "name": "Premier League",
            "_links": {
                "self": {
                    "href": "/tournaments/eng_pl"
                }
            },
            "coverage": {
                "id": "eng",
                "name": "England",
                "_links": {
                    "self": {
                        "href": "/territories/eng"
                    }
                }
            }
        },
        "teams": [
            {
                "id": "manuni_eng",
                "name": "Manchester United",
                "_links": {
                    "self": {
                        "href": "/teams/manuni_eng"
                    }
                }
            },
            {
                "id": "ars_eng",
                "name": "Arsenal",
                "_links": {
                    "self": {
                        "href": "/teams/ars_eng"
                    }
                }
            }
        ],
        "season": {
            "name": "Premier League 2016/2017",
            "_links": {
                "self": {
                    "href": "/tournaments/eng_pl/seasons/20162017"
                }
            }
        },
        "stage": {
            "name": "Main",
            "_links": {
                "self": {
                    "href": "/tournaments/eng_pl/seasons/20162017/stages/main"
                }
            }
        },
        "_links": {
            "self": {
                "href": "/tournaments/eng_pl/seasons/20162017/matches/87261667f928ad0a2078b8c35ab02f43"
            }
        },
        "context": {
            "matchday": 12
        },
        "last_update_time": {
            "date_time": "2016-11-19T14:33:04+00:00",
            "timestamp": 1479565984
        }
    },
    {
        "id": "17878825b2a0db483db33480a74774fc",
        "begin_time": {
            "date_time": "2016-11-19T15:00:00+00:00",
            "timestamp": 1479567600
        },
        "status": {
            "status": "finished",
            "score": [
                1,
                2
            ],
            "finished_after": "2T"
        },
        "tournament": {
            "id": "eng_pl",
            "name": "Premier League",
            "_links": {
                "self": {
                    "href": "/tournaments/eng_pl"
                }
            },
            "coverage": {
                "id": "eng",
                "name": "England",
                "_links": {
                    "self": {
                        "href": "/territories/eng"
                    }
                }
            }
        },
        "teams": [
            {
                "id": "crypal_eng",
                "name": "Crystal Palace",
                "_links": {
                    "self": {
                        "href": "/teams/crypal_eng"
                    }
                }
            },
            {
                "id": "mancit_eng",
                "name": "Manchester City",
                "_links": {
                    "self": {
                        "href": "/teams/mancit_eng"
                    }
                }
            }
        ],
        "season": {
            "name": "Premier League 2016/2017",
            "_links": {
                "self": {
                    "href": "/tournaments/eng_pl/seasons/20162017"
                }
            }
        },
        "stage": {
            "name": "Main",
            "_links": {
                "self": {
                    "href": "/tournaments/eng_pl/seasons/20162017/stages/main"
                }
            }
        },
        "_links": {
            "self": {
                "href": "/tournaments/eng_pl/seasons/20162017/matches/17878825b2a0db483db33480a74774fc"
            }
        },
        "context": {
            "matchday": "Round 12"
        },
        "last_update_time": {
            "date_time": "2016-11-19T17:08:10+00:00",
            "timestamp": 1479575290
        }
    },
murat11 commented 7 years ago

Fixed on Prod. It may take 1-2 hours to become available for all matches