init aspects after all modules are loaded, not within bootstrap

goaop / goaop-zf2-module

Integration module for Go! AOP Framework and ZF2 Framework

MIT License

6 stars 4 forks source link

init aspects after all modules are loaded, not within bootstrap #4

Closed reinfi closed 7 years ago

reinfi commented 7 years ago

This fix is required when you use the listeners config key to register listener before any bootstrap is happening.

If you have an aspect within these listeners or their dependencies the aop aspects are not registered. The aop classloader could not exchange them so any annotation does not work.

With this change every aspect is registered right after the modules are loaded and before any listener is registered or any bootstrapping has happened.

Feel free for any questions.

reinfi commented 7 years ago

nobody's handling pull requests here?

lisachenko commented 7 years ago

Hi! Sorry for the late reply! I'm busy, but still available for short conversations and PR merges.

reinfi commented 7 years ago

No problem. Could you add a tag or a version to the commit so we can refer to it?