search

goaop / goaop-zf2-module

Integration module for Go! AOP Framework and ZF2 Framework
MIT License
6 stars 4 forks source link

Adding tests #8

Closed reinfi closed 7 years ago

reinfi commented 7 years ago

As a result of my previous mistakes I added tests for the goaop zf module. They test everything except the warmup console controller.

Perhaps we should add a .travis.yml to run the tests everytime some pushed something?

lisachenko commented 7 years ago

👍 Great job!

Could I ask you to add .travisci default configuration file to make tests working with CI?

reinfi commented 7 years ago

Done :)

reinfi commented 7 years ago

I decided to remove php 5.5 because it is not really working with the tests.

I think the functionality is covered with the php 5.6 tests as well.

lisachenko commented 7 years ago

Squashed and merged into master. Thank you for writing tests!