search

goat-community / goat

This is the home of Geo Open Accessibility Tool (GOAT)
GNU General Public License v3.0
89 stars 47 forks source link

[BUG] Public transport departure Pie Chart at Freiburg Hauptbahnhof faulty? #2101

Closed UJehle closed 1 year ago

UJehle commented 1 year ago

Summary 📃

  1. When I click on the pie chart at Freiburg Main station, the result window is empty.
  2. Furthermore, there are elements in the legend which don't appear in the map. grafik

Expected Behaviour ✔

  1. The result window contains a result.
  2. The elements in the legend fit to the elements in the map.

Current Behaviour 🔦

  1. The result window doesn't contain a result.
  2. The elements in the legend don't fit to the elements in the map.

Possible Solution 💡

Steps to reproduce 👣

  1. Open GOAT Freiburg
  2. Switch on the pie charts
  3. Click on the main station
  4. See an empty result window

Possible Implementation 📐

This issue might be similar to the one we had at Munich main station.

EPajares commented 1 year ago

@Ebubeker just remove the categories Hochgeschwindigkeit, Fernverkehr and Interregio. And make a condition that skips any other than the default modes. Default modes are U-Bahn, Bahn, Straßenbahn and BUs

p4b-bro[bot] commented 1 year ago

This task/issue closed on Mon Apr 03 2023 ✅

UJehle commented 1 year ago

Are these changes already online? "High speed rail" is now appearing in the pie chart, but "inter regio" is missing although there should be several trains departing. grafik

Also "S-Bahn" is missing in our indicator. grafik

Btw. what is the difference between "Fernverkehr" and "Hochgeschwindigkeitszug"?

Ebubeker commented 1 year ago

I think the missing ones have to do with the data, since these are all the ones which have been provided. The S-bahn might also be included in the Rail since with what I saw online it is "The S-Bahn is the name of hybrid urban-suburban rail systems"

As for Fernverkehr and Hochgeschwindigkeitszug maybe they are different in the aspect of speed and station stops, but I am not quite sure since I am not of this field.

Ebubeker commented 1 year ago

"Fernverkehr" and "Hochgeschwindigkeitszug" are both German words related to transportation, specifically rail transport. However, they refer to different concepts.

"Fernverkehr" is a German term that refers to long-distance travel, usually by train. It can be translated into English as "long-distance traffic" or "long-distance transportation." This term includes all types of long-distance train services, including regional express trains, intercity trains, and high-speed trains.

On the other hand, "Hochgeschwindigkeitszug" is a German term that specifically refers to high-speed trains, also known as bullet trains. This term can be translated into English as "high-speed train." Hochgeschwindigkeitszüge are capable of travelling at speeds of 250 km/h or higher, and they typically connect major cities and destinations within a country or across borders.

In summary, while Fernverkehr refers to all long-distance train services, including high-speed trains, Hochgeschwindigkeitszug specifically refers to high-speed trains.

This is what chat gpt said about this

EPajares commented 1 year ago

Guys please follow my suggestion above: U-Bahn, Bahn, Straßenbahn and Bus

These are the only categories we can show at the moment for more we are not having the sufficient data coverage. S-Bahn is in Bahn. The GTFS data does not know a difference. Please remove all other categories and just escape them with a condition in case they appear.

UJehle commented 1 year ago

Okay I see, I thought you might have discussed something that was not documented in the issue regarding the modes, as now there were even more modes than before and the numbers in the pie charts seemed to be correct at Freiburg Hauptbahnhof. Thus, I thought it's on purpose and wasn't aware that this is a data issue.

The category "Bahn" is currently not included, so this would be new?