goat-community / goat

This is the home of Geo Open Accessibility Tool (GOAT)
GNU General Public License v3.0
89 stars 47 forks source link

Isochrone convert :cyclone: #2230

Closed metemaddar closed 11 months ago

metemaddar commented 1 year ago

Related issues:

metemaddar commented 12 months ago

Manual Test Results

Heatmap Isochrone
Direct Worker Direct Worker
GeoJSON :heavy_check_mark: :heavy_check_mark: :warning: :heavy_check_mark:
CSV :heavy_check_mark: :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:
KML :heavy_check_mark: :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:
Grid N/A :heavy_check_mark: N/A :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:
Network N/A :heavy_check_mark: N/A :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:
Shape File :heavy_check_mark: :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:
PBF N/A :x: N/A :x: :x: :x:
Geo Package :heavy_check_mark: :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:
XLSX :heavy_check_mark: :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:
GeoBuf :heavy_check_mark: :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:

Isochrone

:warning: Isochrone | Direct | GeoJSON

Returns JSON Response Seems attaching all available the POIs

:heavy_check_mark: Isochrone | Direct | CSV

Returns as isochrone.csv

Columns:

:heavy_check_mark: isochrone | Direct | KML

As opened in QGIS: Screenshot from 2023-05-22 09-55-30

:heavy_check_mark: Isochrone | Direct | Grid

Returns grid.bin file

:heavy_check_mark: Isochrone | Direct | Network

Returns Network as JSON Response

:x: Isochrone | Direct | Shape File

Internal Server Error (While converting geojson to shapefile)

:x: Isochrone | Direct | PBF

Internal Server Error (Key Error)

:heavy_check_mark: Isochrone | Direct | Geo Package

As opened in QGIS: Screenshot from 2023-05-22 10-08-31

:heavy_check_mark: Isochrone | Direct | XLSX

Returns isochrone.xlsx Columns seems same as CSV

Heatmap

:heavy_check_mark: Heatmap | Direct | Geojson

Tested with Resolution 6, walking Returns as a normal JSON response

:warning: By default returns all amenities with their classes

:heavy_check_mark: Heatmap | Direct | CSV

Returns as heatmap.csv ID is the h_id value

:heavy_check_mark: Heatmap | Direct | KML

Amenities are attached to the attribute table, but there are additional columns like visibility shown as -1

As opened in QGIS: Screenshot from 2023-05-22 10-28-56

:x: Heatmap | Direct | Shape File

Internal Server Error (By ogr2ogr)

:heavy_check_mark: Heatmap | Direct | Geo Package

Returns as heatmap.gpkg Data is clearly available at attribute table

As opened in QGIS: Screenshot from 2023-05-22 10-35-56

:heavy_check_mark: Heatmap | Direct | XLSX

Returns as heatmap.xlsx It seems the same as CSV :warning: Like isochrone and CSV, the id shown as a scientific number

metemaddar commented 12 months ago

Isochrone at worker side is failing. I need to find the bug. I will update the previous comment after bug fixed.

metemaddar commented 12 months ago

The conversion is now working using workers too.

metemaddar commented 12 months ago

The GeoBuf also tested with QGIS and it works. Now we need to debug shapefile and also add PBF to the convert types. We also need to raise appropriate exception when we ask for network or grid for heatmap at /results endpoint.

metemaddar commented 12 months ago

:heavy_check_mark: Shapefile fixed and tested in direct mode.

metemaddar commented 12 months ago

/results endpoint validated against return_type and data_source.

Heatmap Isochrone
Direct Worker Direct Worker
GeoJSON :heavy_check_mark: :heavy_check_mark: :warning: :heavy_check_mark:
CSV :heavy_check_mark: :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:
KML :heavy_check_mark: :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:
Grid N/A :heavy_check_mark: N/A :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:
Network N/A :heavy_check_mark: N/A :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:
Shape File :heavy_check_mark: :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:
PBF N/A :x: N/A :x: :x: :x:
Geo Package :heavy_check_mark: :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:
XLSX :heavy_check_mark: :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:
GeoBuf :heavy_check_mark: :heavy_check_mark: :heavy_check_mark: :heavy_check_mark:
metemaddar commented 12 months ago

The Shapefile also tested by workers. The only problem is that seems the PBF is not supported directly by ogr2ogr.