search

goat-community / goat

This is the home of Geo Open Accessibility Tool (GOAT)
GNU General Public License v3.0
89 stars 47 forks source link

Enable scenarios with changed way attributes #247

Closed UJehle closed 3 years ago

UJehle commented 4 years ago

Make it possible to also change way attributes (e.g. lit=no to lit=yes) in a scenario.

EPajares commented 4 years ago

This could be a new epic. As we might have several sub-tasks.

EPajares commented 4 years ago

For the next testing cycle in Fürstenfeldbruck it would be important to be able to change especially the wheelchair tag. I would say per default a new way should be wheelchair = 'yes'

UJehle commented 4 years ago

@EPajares @majkshkurti what is the progress of this issue?

EPajares commented 4 years ago

No real progress so far. UI logic is easy but I still need to build the backend. More work. What we should have by the end of the week is that new ways are wheelchair=yes. Rest we can do later.

UJehle commented 3 years ago

As a consequence of the possibility to define (and in future change) path attributes, the defined information (e.g. wheelchair = yes) should also be visible after uploading the drawn path. This information could be displayed either when the user hovers over the feature or by proving a new "info" button, which enables the user to click on features and opens an infobox (within the infobox, also the option to change the attributes could be provided).

info

EPajares commented 3 years ago

Thanks @majkshkurti! Client side it works. I realized that it would make sense to label features for which only the attributes were changed. Otherwise it is hard to tell if the feature also faced modified geometrically. I would propose a new column in the ways_modified table. I think we might have to add this in the future also to the other modified-tables to keep consistancy. I will call the column edit_type and we could pass the values attributes_only, drawn geometry, modified geometry.