goat-community / ums

Map4Citizens (EIT)
https://citizens.plan4better.de/
GNU General Public License v3.0
0 stars 0 forks source link

Old bugs and texts still appearing in the mobile version? #213

Closed UJehle closed 1 year ago

UJehle commented 1 year ago

Describe the bug I just opened Map4Citizens on the phone and realized that some old bugs and texts are still appearing there.

  1. blue box sitting on top of the text: image

  2. The text that is shown here is still the placeholder text that we used a couple of months ago. It's not in line with the text in the desktop version: image

  3. This bug is appearing when trying to adjust the personal flower: image

To Reproduce Steps to reproduce the behavior:

  1. Open Map4Citizens on the smartphone (I used iPhone 11)

Desktop (please complete the following information):

@cinaaaa could you please have a look and fix these? Thanks!

cinaaaa commented 1 year ago

Thanks, Ulrike, Yeah I think that we neglected the mobile version for a while. I'll check this and fix all the remaining stuff there.

UJehle commented 1 year ago

Thanks! would be good if you could then also check all the other functionalities and make sure that all the changes we did on the desktop version are also reflected in mobile.

cinaaaa commented 1 year ago

Image

@UJehle Regarding the flower text, the desktop is same as the mobile, is there something wrong with this text.

UJehle commented 1 year ago

@cinaaaa thanks for raising this. As my settings were saved in cache, I didn't realize that this screen is still existing :D Could you adjust it to the following:

German:

Die 'Flower of Proximity' dient dazu, ihr persönliches Mobilitätsprofil zu erstellen. Basierend auf Ihren Einstellungen wird der 15-Minuten-Score angepasst.

Wie sieht Ihre perfekte 15-Minuten-Stadt aus?

Left button: Zurück

Right button: Profil erstellen

English:

The 'Flower of Proximity' is used to create your personal mobility profile. Based on your settings, the 15-minute score is adjusted.

What does your perfect 15-minute city look like?

Left button: Back

Right button: Create profile

cinaaaa commented 1 year ago

Thanks @UJehle this is ready for review now!

UJehle commented 1 year ago

Thanks @cinaaaa, the texts look good.

I just tested the whole user flows and came across two further points:

  1. When the user opens the website the first time and wants to calculate an isochrone, the "create your flower" window opens. But actually this is not needed, as we can just use the default settings for the calculation.
  2. Could you adjust the German text in the button on this section to "Bearbeiten": grafik
UJehle commented 1 year ago

Thanks @cinaaaa. Looks good to me.

p4b-bro[bot] commented 1 year ago

This task/issue closed on Thu Jun 08 2023 ✅

p4b-bro[bot] commented 1 year ago

This task/issue closed on Fri Jun 09 2023 ✅

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.