search

goat-systems / go-tezos

Go Tezos Is a Go library that exposes and builds upon the Tezos RPC.
MIT License
71 stars 45 forks source link

bytes.Equal instead of reflect.DeepEqual #167

Open utdrmac opened 3 years ago

utdrmac commented 3 years ago

https://github.com/goat-systems/go-tezos/blob/master/internal/crypto/crypto.go#L96

This section of code is comparing equality of two byte slices. Is it necessary to use such a bloated package as reflect in this case? Could bytes.Equal() be used instead; especially considering that "bytes" is already included in this package and this is the only use of reflect.

DefinitelyNotAGoat commented 3 years ago

I will take a look at this when I review the package to make it public.