search

goatcorp / Dalamud

FFXIV plugin framework and API
GNU Affero General Public License v3.0
1.18k stars 272 forks source link

[API 10] Migration to EXDSchema #1785

Open KazWolfe opened 6 months ago

KazWolfe commented 6 months ago

[!NOTE] This Issue is based in Lumina rather than Dalamud, but exists here for tracking and auditing purposes. If there are any known issues with moving to EXDSchama from a plugin perspective, please document them here.

EXDSchema seems to be the preferred mechanism for accessing EXD data in Lumina now, but it is currently named GeneratedSheets2. With API 10, we have an opportunity to move it to GeneratedSheets and allow developers to update their plugins accordingly.

KazWolfe commented 6 months ago

Per Perchbird in Dalamud Discord:

there are a few actual bugs in the sheet code generation on the lumina side that need to be fixed; i forget the exact fields but there is a latent var in Achievement that shouldn't be generated and there's a nested array in CharaMakeType (i think) that is generated improperly

no, i consider those kinds of bugs to be regressions and too detrimental to replace the original impl at this moment plus there's no telling how many more there are

This change can be safely deferred indefinitely if required, but should still be tracked with an eventual hope of targeting.