search

goatcorp / Dalamud

FFXIV plugin framework and API
GNU Affero General Public License v3.0
1.19k stars 270 forks source link

Crash when ReShade of specific versions is also injected to the game #1836

Closed liuxd17thu closed 4 months ago

liuxd17thu commented 4 months ago

How to produce:

  1. Install custom ReShade build of this commit (https://github.com/crosire/reshade/commit/bb651288247fec7f2c1b9bdfc4a8b08a25ac9a62), or any other versions newer.
  2. Launch FFXIV with Dalamud enabled The Dalamud icon (for dalamud setting / plugin manager) is missing, but it should have been on the left side of game title screen. Meanwhile ANY keyboard input will make Dalamud crash immediately Crash

The game integrity is good, and there are not any Dalamud plugins installed at all. I suppose there are some conflictions between ReShade's recent code changes and Dalamud's ImGui.

Crash tspack is here: crash-20240614131357.zip

goaaats commented 4 months ago

Is this the exact commit that's causing the issue? Did you bisect reshade to arrive at it?

liuxd17thu commented 4 months ago

Is this the exact commit that's causing the issue? Did you bisect reshade to arrive at it?

Yes, everything is fine with the previous commit (https://github.com/crosire/reshade/commit/30abcf65542b5a6de19a3ec3f3e5ae41b35b2290).

Soreepeong commented 4 months ago

Can't see any association with those reshade commits with Dalamud, but the crash log itself makes sense on its own. The above PR should fix this problem, at least for this stack trace in particular.