search

goatcorp / Dalamud

FFXIV plugin framework and API
GNU Affero General Public License v3.0
1.17k stars 273 forks source link

Game crashes when entering chara make/aesthetician #192

Closed seathasky closed 3 years ago

seathasky commented 4 years ago

Describe the bug here: Game crashes when I typed /xlplugins. It opens the window briefly and the FF14 crashes 4 seconds later.

Steps to reproduce the bug: typing /xlplugins. Plugins still work outside of typing to get plugin list. I tested everything that i have installed.

Expected behavior typing /xlplugins should populate a list of plugins and their config.

Other information (please complete the following information): Operating System: Windows 10 latest update XIVLauncher version: 5.1.1.0 Launching as admin?: no Using Steam?: no Addons/Plugins enabled: mouseover, soundsetter, xivcombo, and marketplace.

Gshade also installed. But i've tested with and without and still get the crashes. I've also tested in a base game install with no addons, plugins etc, just fresh install and I do not get crashes. Something with XIV Launcher is crashing the game.

seathasky commented 4 years ago

Update: Game 100% always crashes while in Aesthetician as well! I've tested in a base game install and XIVLauncher not installed and I do not get crashes. This also happens for my wife on using XIVLauncher.

Macapple96 commented 4 years ago

While the /xlplugins crashes are not my case, I confirm for the Aesthetician crashes, which also happen in the Character Creation screen. They also happened when using a Retainer Fantasia and loading appearance data, crash happened around 5-10 seconds in the editing screen.

Crash didn't happen when opening the game through the official launcher. No error is returned, the game just closes.

stevenhay commented 4 years ago

I can also confirm Aesthetician, Character Creation and Retainer Creation crashes, happens both for me and a friend of mine.

seathasky commented 4 years ago

/xlplugins crash seemed to be a fluke? After update it seemed to go away. I still have the Aesthetician, Character Creation and Retainer Creation crashes though.

Caraxi commented 4 years ago

Aesthetician, Character Creation and Retainer Creation crashes though.

sounds like CMTool

stevenhay commented 4 years ago

Even without CMTool being open the client still crashes (albeit rarely for me) at the Aesthetician etc. It happens a lot for a friend of mine, every time they try and change their appearance they need to relog on the official client because this one simply crashes each time. If it was CMTool surely the official client would crash, too? (And CMTool would need to be open)

goaaats commented 4 years ago

Hi, neither me nor the other devs ever encountered this. If you can, please put together a complete list of steps of how to get to the crash and attach a "System Info" from the official launcher at the time of the crash.

If you wish, you can dm this to me on discord at goat#0909

stevenhay commented 4 years ago

Sure, just moving house at this very moment but when I a little time I'll look into it some more and post some more detailed info

seathasky commented 4 years ago

Yea @goaaats the /xlplugins crash thing worked itself out thankfully. Good call on the title change. Me and my wife both crash on make/aesthetician as well 100% of the time.

stevenhay commented 4 years ago

Complete list of steps to reproduce is:

  1. Login (edit: I do have some mods and ReShade, perhaps that could be it? Still unsure why the normal client wouldn't crash and this one would though, as that's the only thing that's changing)
  2. Go to Aesthetician
  3. See if you crash (doesn't happen every time for me, it happened twice in 5 attempts earlier)

I've DM'd you a video of it happening to me and my System Info, nothing seems to show up that looks out of the ordinary from the default logging when running the client via Visual Studio in debug mode.

ff-meli commented 4 years ago

This doesn't address this particular crash, but just a note about the previous comment -

If you run the game through a debugger, or attach one, you need to have done something to mitigate the checks the game has, or it will intentionally crash itself after a variable length of time.

stevenhay commented 4 years ago

I see, that's good to know! but I wasn't attaching a debugger or anything, simply running this client in debug mode which should start the game normally as it's just a launcher, and even if not, it crashed within a minute and 30 seconds and at the same time it usually would with the reported issue :( it could be a coincidence but I personally don't think so

Khitiara commented 4 years ago

I just got the crash in chara customization screen three times in the row trying to hire retainers, cmtool isnt open

Khitiara commented 4 years ago

Disabling the ingame addon fixed it so its definitely an issue with either the addon or plugins

Khitiara commented 4 years ago

Managed to confirm the issue is with at least one plugin in particular but im not sure which or what because theres' no logs being generated for the crash.

aers commented 4 years ago

Binary search for the crashing plugin (disable half your plugins at a time)? A crash log probably wouldn't even be much help since its most likely crashing in xiv code not plugin code

Khitiara commented 4 years ago

I would if i was using any of the plugins i removed before noticing it starting to work. I know i removed macrorecursion, peepingtom (my personal hunch as for the suspect), and a bunch of plugins that were disabled anyway

Khitiara commented 3 years ago

whee.zip as per discussion in discord after some testing, issue is consistent with goodmemory and fpsplugin installed but not with either individually, and happened once but not reproducible with fpsplugin and richpresence

goaaats commented 3 years ago

This should not be happening anymore with the plugins currently released.