goatcorp / Dalamud

FFXIV plugin framework and API
GNU Affero General Public License v3.0
1.18k stars 272 forks source link

Plugin matching in collections broken across devices #1992

Open Quartos opened 2 months ago

Quartos commented 2 months ago

I'm using the "JustBackup" plugin to keep my dalamud files consistent across 2 devices. Essentially, it just saves all plugin configurations and the dalamudConfig.json (which is likely relevant here). After restoring the backup from device A onto device B, the plugin collections are broken. The collections themselves are present, but the plugins cannot be found.

Dalamud seemingly accounts for this case and shows the following for all plugins:

grafik

Yet when pressing this button, nothing happens.

From a naive outsider perspective, it seems like the "WorkingPluginId" that is stored inside the json for each plugin is used for the references, which does not work due to the device change. Dalamud then detects that there is a similar plugin by using the "InternalName" field, however the matching still fails for some reason. What's even more interesting, for plugins that were installed only on device A and not device B, Dalamud even offers me to download them, yet after the download, the reference is still broken and cannot be repaired by the means above.

Steps to reproduce would (likely) be to arbitrarily change the WorkingPluginID so that the above option shows.

Would be very helpful if this could be fixed! Plugin collectionsbecame an integral QoL improvement to me, and I can imagine it's the same for many people that need to move between places frequently.

goaaats commented 2 months ago

That's definitely a bug. I can try to have a look some time.