goatcorp / Dalamud

FFXIV plugin framework and API
GNU Affero General Public License v3.0
1.17k stars 273 forks source link

Resizing game window breaks in-game UI buffers #38

Closed goaaats closed 4 years ago

goaaats commented 4 years ago

image image

Can reproduce this locally, with newest GShade.

ff-meli commented 4 years ago

Hnadling ResizeBuffers() properly didn't seem to have any effect on this. It seems like maybe ImGui is not properly resizing its clip/scissor rects, and is also for some reason applying them to the ui layer, which generally shouldn't happen because of the state backup and restore.

ImGui in general seems to not really support resizing well except in an experimental branch. I don't think we can really tear down and rebuild the whole thing, because that would likely break state for any ui that is currently open. Will play with it more later.

ff-meli commented 4 years ago

Should be fixed in that PR. Make sure to update the submodule too, as half the changes are there.

goaaats commented 4 years ago

Thanks a lot!