search

goatcorp / Dalamud

FFXIV plugin framework and API
GNU Affero General Public License v3.0
1.13k stars 265 forks source link

Missing FontAwesome 5 Free Icons in IconFont #685

Open MalRD opened 2 years ago

MalRD commented 2 years ago

https://github.com/goatcorp/Dalamud/blob/a2305c7a1d39396076514df53f2451a037af7685/Dalamud/Interface/Internal/InterfaceManager.cs#L525

The IconFont currently only includes icons in Font Awesome 5 Free-Solid-900.otf. To include all of the free icons, Font Awesome 5 Free-Regular-400.otf and Font Awesome 5 Brands-Regular-400.otf should be included as well.

Caraxi commented 2 years ago

we probably don't want to use the entire font atlas for just font awesome icons

MalRD commented 2 years ago

I put a commit in my fork that shows the change that need to be made even if no new font is added, as some of the unicode values are wrong in FontAwesomeIcon.cs. They were inadvertently changed during a code cleanup.

I was able to find a few icons that didn't match the latest FontAwesome values (and upon further inspection, didn't exist in 5.0.9), but these are Brand icons, so pointing to nothing doesn't cause any problems.

Excluding the Brand file makes sense to me, unless someone can describe a good use for it. There's a huge number of icons in that, most of which are useless in the context of addons. Regular is smaller, but upon further reflection, I'm not sure if there is any iconography that is exclusive to Regular. When someone mentioned icons were missing and scrolled through /xldata, I figured they meant the missing fonts, but it could just be the ~80 or so fonts that have the wrong unicode value in the FontAwesomeIcon.cs file.