search

goatcorp / Dalamud

FFXIV plugin framework and API
GNU Affero General Public License v3.0
1.25k stars 280 forks source link

Gauge bar values (Ninja) #978

Closed telinit closed 2 years ago

telinit commented 2 years ago

Hey. It seems that ninja gauge bar values are broken after the 6.2 update. I use DelvUI and it shows wrong numbers:

image

I turned on the developer mode and looked into the gauge struct's values: image

Then I followed the address in my debugger (x64dbg) and here's what I saw: image

I believe, HutonTimer value from NinjaGauge struct should be ushort (2 bytes) now, not int (4 bytes) and other fields should have their offsets changed accordingly.

I'm not sure how can I test this change if I build Dalmud from the sources. How do I use my own local version instead of the FFXIVLauncher's own which it downloads and installs automatically?

Anyway, I hope the info above helps to fix this bug.

yurisim commented 2 years ago

Poohky made changes to client structs here

https://github.com/aers/FFXIVClientStructs/commit/537b6a60467d204ff2d72ef36d1a08dc17a2c9a8

That addresses this. Apparently we just got wait for dalamund to incorporate the new client structs.

However I also would like to know how I get my own version of these fixes compiled @_@