goatcorp / FFXIVQuickLauncher

Custom launcher for FFXIV
https://goatcorp.github.io/
GNU General Public License v3.0
2.85k stars 333 forks source link

Fix xlcore oathloginexception #1591

Closed rankynbass closed 4 months ago

rankynbass commented 4 months ago

Adds logic to OauthLoginException to deal with XL.Core error messages. There may be a way to do it by modifying the regex, but this works fine in my testing. I created a temporary env variable to set the login state manually. The errors will now show up with the error text instead of displaying "Unknown error".

rankynbass commented 4 months ago

Alternately, to make it really simple, we could just change one line (28), to return the document string instead of null. Then any message that didn't match the regex would just get used as-is, which would include those from XL.Core.

rankynbass commented 4 months ago

Closing this; can be fixed on XL.Core side.