Apps not getting added to Auto-Launch

[dustin-lennon]

Describe the bug here: When adding new applications to the auto launch list, they are not getting added.

Steps to reproduce the bug:

1. Click on Settings
2. Click on Auto-Launch
3. Add new application (i.e, ACT or TeamCraft)
4. Application does not get added to list after save

Expected behavior Applications get added to the auto launch list after adding.

Screenshots If applicable, add screenshots to help explain your problem.

Other information (please complete the following information): Operating System: XIVLauncher version: 4.7 - Pre Release Launching as admin?: No Using Steam?: No Addons/Plugins enabled: Trying to add ACT to run as Admin & TeamCraft

Additional information Add any other context about the problem here.

launcherConfigV3.json

{
  "AdditionalLaunchArgs": "",
  "AutologinEnabled": "false",
  "CharacterSyncEnabled": "false",
  "GamePath": "E:\\Games\\SquareEnix\\FINAL FANTASY XIV - A Realm Reborn",
  "InGameAddonEnabled": "true",
  "SteamIntegrationEnabled": "false",
  "IsDx11": "true",
  "Language": "English",
  "UniqueIdCacheEnabled": "false",
  "AddonList": "[{\"$type\":\"XIVLauncher.Addon.AddonEntry, XIVLauncher\",\"IsEnabled\":true,\"Addon\":{\"$type\":\"XIVLauncher.Addon.RichPresenceAddon, XIVLauncher\",\"Name\":\"FFXIV Discord Rich Presence\"}}]"
}

[Myrhial]

I can replicate this. However, when you close and open the launcher settings, the application you added will be there. So it seems to just be a display issue. Hope that helps.

[dustin-lennon]

I have closed and reopened the launcher many times and they are never there.

On Sat, Feb 22, 2020, 7:15 AM Nina Arens notifications@github.com wrote:

I can replicate this. However, when you close and open the launcher settings, the application you added will be there. So it seems to just be a display issue. Hope that helps.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/goaaats/FFXIVQuickLauncher/issues/164?email_source=notifications&email_token=AAAWPPKZH2QRWBNO5G22VWLREEJMNA5CNFSM4KZOFCRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMU65GI#issuecomment-589950617, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAWPPNI5PPV5SRE7T4TMRLREEJMNANCNFSM4KZOFCRA .

[Zyian]

Debugging this a little: Found that https://github.com/goaaats/FFXIVQuickLauncher/blob/master/XIVLauncher/Windows/SettingsWindow.xaml.cs#L156 When the addon goes to get appended to the addonlist, the Add() fails leaving only the original list in its place

[goaaats]

This is fixed in https://github.com/goaaats/FFXIVQuickLauncher/commit/d6b587da3e02a7a533b146003a277527613c6ecc