goatcorp / FFXIVQuickLauncher

Custom launcher for FFXIV
https://goatcorp.github.io/
GNU General Public License v3.0
2.8k stars 325 forks source link

One-Time Password dialogue fails to reopen #215

Open pigsflew opened 4 years ago

pigsflew commented 4 years ago

Describe the bug here: Occasionally the FFXIV Launcher will fail to show the dialogue for OTP entry, but the window becomes unresponsive as though it has shown it. Additionally, an empty window appears on the taskbar. I need to close out that window from the taskbar, and restart XIVQL before it will appear again.

My best guess is that there's a shared library issue happening?

Steps to reproduce the bug: It happens sometimes randomly, but I think I can consistently produce the issue if I start XIVQL, then start a VM (in this case, Nox, an Android VM based on VirtualBox), then try to log in.

1. Run FFXIVQuickLauncher
2. Run NoxVM
3. Attempt to log in with OTP.

Expected behavior The OTP entry modal should open.

Screenshots missing-otp-entry

Other information (please complete the following information): Operating System: Windows 10 Home build 1909 XIVLauncher version: v4.9.2.0 - bfd5a4c - 4.0.30319.42000 Launching as admin?: No Using Steam?: No Addons/Plugins enabled: Chat Extender Plugin 1.2.0.0, Discord Rich Presence 1.1.0.0

Additional information

goaaats commented 4 years ago

I've heard about this bug, but I've never encountered it personally - will try again though!

pigsflew commented 4 years ago

On a whim, I switched to Memu and tried it again, and this doesn't happen.

It seems like this may actually be a Nox issue, and not an XQL issue, so maybe this can be closed.

Thanks!

coopyey commented 4 years ago

Just to throw my two cents in - I have had this happen on a rare occasion. I normally only have Firefox, VoiceMod, Spotify, and Discord up when it does happen. In every instance after the first I have been able to type my OTP into the invisible box and hit the enter key and it will pass the OTP along fine and work without issue as long as I don't click anything else. The instances in which it happened seemed random, but mostly it happened far enough apart that I didn't notice a pattern that made it happen, and I'm sure I'm forgetting details because it's not a common happening.

I just did a fresh install so I can't give you the version of Windows or XIVL that it happened under, but I can give the rest:

OS: Windows 10 Home, unsure build XIVLauncher: unsure build Launching as admin: No Using Steam: Yes Addons: Chat Extender, Music Player, Discord Rich Presence

As a note, I do have virtualization enabled on my machine and do have VMWare Workstation with a handful of VMs, but I never run them in parallel with launching or playing the game.

katarai commented 3 years ago

I can reproduce this (or a very similar problem) 100% of the time by simply typing in a password, triggering the OTP prompt window by hitting the [Enter] key (not by clicking the 'Log In' button with the mouse), and then canceling out of that window by pressing 'Cancel'.

Every subsequent attempt to trigger the OTP prompt fails to spawn the window, whether by clicking the 'Log In' button or pressing the [Enter] key.

Notably, this isn't an issue if you never use the [Enter] key on the keyboard, or if you type in the incorrect OTP instead of hitting the 'Cancel' button.